Move Raspberry Pi 4 support to a module

hosts/2maccabees/default.nix

@@ -7,8 +7,8 @@
 		./home-assistant.nix
 		./networking.nix
 		./vhosts.nix
-		../../profiles/rpi4.nix
 		../../profiles/home.nix
 	];
 	networking.hostName = "2maccabees";
+	greg.rpi4.enable = true;
 }

hosts/2maccabees/hardware-configuration.nix

@@ -4,28 +4,28 @@
 { config, lib, pkgs, modulesPath, ... }:
 
 {
-  imports =
+	imports =
-    [ (modulesPath + "/installer/scan/not-detected.nix")
+		[ (modulesPath + "/installer/scan/not-detected.nix")
-    ];
+	];
 
-  boot.initrd.availableKernelModules = [ "xhci_pci" "usbhid" "usb_storage" "uas" ];
+	boot.initrd.availableKernelModules = [ "xhci_pci" "usbhid" "usb_storage" "uas" ];
-  boot.initrd.kernelModules = [ ];
+	boot.initrd.kernelModules = [ ];
-  boot.kernelModules = [ ];
+	boot.kernelModules = [ ];
-  boot.extraModulePackages = [ ];
+	boot.extraModulePackages = [ ];
 
-  fileSystems."/" =
+	fileSystems."/" ={
-    { device = "/dev/disk/by-uuid/35f9a49a-b557-4eb3-a013-2afca7a990e4";
+		device = "/dev/disk/by-uuid/35f9a49a-b557-4eb3-a013-2afca7a990e4";
-      fsType = "btrfs";
+		fsType = "btrfs";
-    };
+	};
 
-  fileSystems."/boot" =
+	fileSystems."/boot" = {
-    { device = "/dev/disk/by-uuid/A982-C8A3";
+		device = "/dev/disk/by-uuid/A982-C8A3";
-      fsType = "vfat";
+		fsType = "vfat";
-    };
+	};
 
-  swapDevices =
+	swapDevices = [ {
-    [ { device = "/dev/disk/by-uuid/4b6f2dc4-d845-4ec4-81f2-4f61bb3f282d"; }
+		device = "/dev/disk/by-uuid/4b6f2dc4-d845-4ec4-81f2-4f61bb3f282d";
-    ];
+	} ];
 
-  powerManagement.cpuFreqGovernor = lib.mkDefault "ondemand";
+	powerManagement.cpuFreqGovernor = lib.mkDefault "ondemand";
 }

modules/default.nix

@@ -3,5 +3,6 @@
 {
 	imports = [
 		./proxy.nix
+		./rpi4.nix
 	];
 }

modules/rpi4.nix

@@ -0,0 +1,43 @@
+{ config, lib, pkgs, ... }:
+
+let
+	cfg = config.greg.rpi4;
+
+in with lib; {
+	options = {
+		greg.rpi4 = {
+			enable = mkEnableOption "Enable support for Raspberry Pi 4s";
+		};
+	};
+
+	config = mkIf cfg.enable {
+		boot = {
+			# This prevents us from having to compile our own kernel
+			kernelPackages = pkgs.linuxPackages_rpi4;
+			kernelParams = [
+				"8250.nr_uarts=1"
+				"console=ttyAMA0,115200"
+				"console=tty1"
+				"cma=128M"
+			];
+
+			loader = {
+				raspberryPi = {
+					enable = true;
+					version = 4;
+				};
+
+				# Use the extlinux boot loader. (NixOS wants to enable GRUB by default)
+				grub.enable = false;
+
+				# Enables the generation of /boot/extlinux/extlinux.conf
+				#generic-extlinux-compatible.enable = true;
+			};
+		};
+
+		environment.systemPackages = with pkgs; [
+			raspberrypifw
+			usbutils
+		];
+	};
+}

profiles/rpi4.nix

@@ -1,33 +0,0 @@
-# Base configurations for Raspberry Pi 4s
-{ config, pkgs, ... }:
-
-{
-  boot = {
-    # This prevents us from having to compile our own kernel
-    kernelPackages = pkgs.linuxPackages_rpi4;
-    kernelParams = [
-      "8250.nr_uarts=1"
-      "console=ttyAMA0,115200"
-      "console=tty1"
-      "cma=128M"
-    ];
-
-    loader = {
-      raspberryPi = {
-        enable = true;
-        version = 4;
-      };
-
-      # Use the extlinux boot loader. (NixOS wants to enable GRUB by default)
-      grub.enable = false;
-
-      # Enables the generation of /boot/extlinux/extlinux.conf
-      #generic-extlinux-compatible.enable = true;
-    };
-  };
-
-  environment.systemPackages = with pkgs; [
-    raspberrypifw
-    usbutils
-  ];
-}