Add Ansible linting and other stuff

ansible/roles/vmware/tasks/has_package.yml

@@ -1,5 +1,6 @@
 - name: create hgfs dir
   become: true
-  file:
+  ansible.builtin.file:
     state: directory
     path: /mnt/hgfs
+    mode: 0700

ansible/roles/vmware/tasks/legacy.yml

@@ -1,20 +1,23 @@
 - name: create mount point
   become: true
-  file:
+  ansible.builtin.file:
     path: /mnt/vmware
     state: directory
+    mode: 0700
 
 - name: mount iso file
   become: true
-  command: mount -o loop,ro {{ ansible_user_dir }}/linux.iso /mnt/vmware
+  ansible.builtin.command: mount -o loop,ro {{ ansible_user_dir }}/linux.iso /mnt/vmware  # noqa command-instead-of-module
+  changed_when: false
 
 - name: create tmp dir
-  file:
+  ansible.builtin.file:
     path: /tmp/vmware
     state: directory
+    mode: 0700
 
 - name: untar tools
-  command: |
+  ansible.builtin.command: |
     set -ex
     tar zxf /mnt/vmware/VMWareTools-*.tar.gz -C /tmp/vmware
     sudo /tmp/vmware/vmware-tools-distrib/vmware-install.pl --default --force-install
@@ -24,7 +27,7 @@
 
 - name: remove files
   become: true
-  file:
+  ansible.builtin.file:
     path: "{{ item }}"
     state: absent
   loop:
@@ -32,7 +35,7 @@
     - "{{ ansible_user_dir }}/linux.iso"
 
 - name: add content to /etc/vmware-tools/locations
-  blockinfile:
+  ansible.builtin.blockinfile:
     block: |
       remove_answer ENABLE_VGAUTH
       answer ENABLE_VGAUTH no
@@ -41,5 +44,5 @@
 
 - name: finish up installs
   become: true
-  command: /usr/bin/vmware-config-tools.pl --default --skip-stop-abort
+  ansible.builtin.command: /usr/bin/vmware-config-tools.pl --default --skip-stop-abort
   changed_when: false

ansible/roles/vmware/tasks/main.yml

@@ -1,5 +1,5 @@
 - name: read variables
-  include_vars: "{{ item }}"
+  ansible.builtin.include_vars: "{{ item }}"
   loop:
     - "{{ role_path }}/vars/{{ ansible_facts.distribution }}.yml"
     - "{{ role_path }}/vars/{{ ansible_facts.distribution }}-{{ ansible_facts.distribution_major_version }}.yml"
@@ -7,19 +7,19 @@
 
 - name: install vmware related packages
   become: true
-  package:
+  ansible.builtin.package:
     name: "{{ vmware_packages }}"
     state: present
 
 - name: modern systems
-  import_tasks: has_package.yml
+  ansible.builtin.import_tasks: has_package.yml
   when: >-
     ansible_distribution_name == 'fedora' or
     (ansible_distribution_name == 'debian' and
     ansible_distribution_major_version > '8')
 
 - name: legacy builds
-  import_tasks: legacy.yml
+  ansible.builtin.import_tasks: legacy.yml
   when: >-
     (ansible_distribution_name == 'debian' and
     ansible_distribution_major_version <= '8')